This repository has been archived by the owner on Nov 25, 2022. It is now read-only.
Fix Element Desktop lint step #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#142 added an extra CI step, but since the plugins are part of each step, that change meant that the pre-existing lint step no longer had a Docker image. This fixes things up by setting up the plugins for each step.
richvdh
approved these changes
May 5, 2021
|
took me a while to clock you were talking about buildkite plugins rather than lint plugins 😆 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#142 added an extra CI step, but since the plugins are part of each step, that change meant that the pre-existing lint step no longer had a Docker image.
This fixes things up by setting up the plugins for each step.
This is safe to merge at any time.